Improve the axum entry #8014
Merged
Improve the axum entry #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea what's broken in CI, seems to be about Docker which I didn't modify. |
|
Yes, the toolset is failing. Check #8013 |
|
@volyrique That commit is already part of the history on my branch. |
|
The point is that that commit should be the last commit before your changes - right now your PR is on top of a broken commit. |
jplatte
force-pushed
the
jplatte/up-axum
branch
from
a348454 to
2655279
Compare
|
Okay, done. Just doing |
|
I suspect it will still fail though. The |
… and order / group / merge imports consistently.
jplatte
force-pushed
the
jplatte/up-axum
branch
from
2655279 to
a860e22
Compare
franz1981
pushed a commit
to franz1981/FrameworkBenchmarks
that referenced
this pull request
Jun 23, 2023
* axum: Upgrade dependencies * axum: Remove identity cast * axum: Use state instead of extensions … and order / group / merge imports consistently. * axum: Use str::parse instead of invoking FromStr directly * axum: Use implicit format-args captures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly: Upgrade dependencies, use state instead of extensions.