[toolset] 🔥 Revert "drop permissions of container to match host system (#8007)" #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we need to add |
joanhey
changed the title
Merged
|
@joanhey good point. for some reason, i thought we were doing it that way and that's why i accepted those PRs. good catch |
|
What can I do to get these changes back in? More than happy to diagnose the issues |
franz1981
pushed a commit
to franz1981/FrameworkBenchmarks
that referenced
this pull request
Jun 23, 2023
TechEmpower#8007)" (TechEmpower#8013) * Revert "drop permissions of container to match host system (TechEmpower#8007)" This reverts commit 1cf4924. * [ci lang-only php] To test CI * [ci run-all] To test CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nbrady-techempower fail in GH actions and in local
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/4392558706/jobs/7692392335#step:7:1068
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/4392721211/jobs/7692665726#step:7:1068
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/4393389504/jobs/7693834515#step:7:1077
In local fail with permission denied, when building the wrk dockerfile.
Affected PRs: #8010 #8011 #8012 #8014 #8015 #8016 #8017 #8020