finatra: Remove setting flag value #7943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In PR #7928 it was pointed out that the Finatra benchmark had been failing, due to a
failure of the server startup. Example logs here.
A change was made in Finatra in the middle of 2022 to remove a deprecated logging
shim which provided JUL logging configuration via command line flags. The consequence is
that setting this flag will now cause the server to fail to start (since the flag is no longer
defined anywhere in the server).
Solution
The solution is to remove the setting of this flag via the cmd line. This flag did not do anything
previously and should not be set. Having it in the benchmark was in error.
Result
The Finatra server under test should now start.
Testing
Tested via the tfb script: