Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not work with lastest electron #37

Closed
wangxiexe opened this issue Aug 17, 2016 · 2 comments
Closed

not work with lastest electron #37

wangxiexe opened this issue Aug 17, 2016 · 2 comments

Comments

@wangxiexe
Copy link

  1. I found there is still es6-promise reference even you mentioned in lastest version it will be remove

Promise = require('es6-promise').Promise;

in dist/index.js

  1. then I installed es6-promise and it does not have any error now, but it does not make my app lanuch on windows startup by doing
    appLauncher.enable()

My electron is v1.3.3

  1. what I want is auto launch as minimised on tray, hope this feature can be provied.

Thanks.

@joeferraro
Copy link

joeferraro commented Aug 19, 2016

Was the source re-compiled before pushing the update to npm? I see that es6-promise was removed from /src, but when I npm install references to es6-promise still remain in /dist

@smithalan92
Copy link
Contributor

Hey @wangxiexe and @joeferraro , your both right, 3.0.0 was never rebuilt before publishing. We've published those changes now as 4.0.0 just so anyone using 3.0.0 doesnt get the update in case they're still using the es6-promise module. @wangxiexe I'm going to close this issue. Feel free to open another issue if v4 doesn't solve your problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants