Fix/live stream duration #653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
|
don't merge. and don't test |
|
So... mark it as a draft, then? |
litetex
reviewed
Jun 13, 2021
...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java
Show resolved
Hide resolved
|
I found out that the "now playing" overlay is not only present on live streams, but all streams. The overlay is shown when there is a play queue in YouTube and the stream is playing. Unfortunately, we cannot tell whether a stream is live stream or not when the "LIVE" badge is missing. That is the case when the stream is a never ending stream like a TV channel or news program and already running for a specific time (> 24 hours). |
|
Oh, ok. Let's revert #651 then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #651
Fixed recognizing all streams as live streams
Also recognize streams with "NOW PLAYING" thumbnail overlay as live streams
Thanks to @litetex for noticing the regression introduced in #651.