Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YouTube] Fix getting stream type of live streams #651

Merged
merged 1 commit into from
Jun 12, 2021
Merged

[YouTube] Fix getting stream type of live streams #651

merged 1 commit into from
Jun 12, 2021

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jun 8, 2021 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Live streams are sometimes not recognized as such. That is causing the duration extraction to fail.

Fixes https://github.com/TeamNewPipe/NewPipeExtractor/runs/2769405487?check_suite_focus=true#step:5:169

@TobiGr TobiGr added bug Issue is related to a bug youtube service, https://www.youtube.com/ labels Jun 8, 2021
Stypox
Stypox requested changes Jun 9, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good; I trust you that this works ;-)

...org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java Outdated Show resolved Hide resolved
@TobiGr TobiGr merged commit 0cb48e3 into dev Jun 12, 2021
@opusforlife2 opusforlife2 deleted the fix/streamType branch June 13, 2021 07:16
@litetex
Copy link
Member

litetex commented Jun 13, 2021

@TobiGr
Code seems to be faulty:
Now every video is shown as "LIVE":
grafik

Please check:

NewPipeExtractor/extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemExtractor.java

Line 76 in 0cb48e3

|| thumbnailOverlay.getObject("thumbnailOverlayTimeStatusRenderer")

Looks like the "or" || should be an "and" &&

@TobiGr
Copy link
Contributor Author

TobiGr commented Jun 13, 2021

Uhm. No. That should not be the case. Let me take a look. Thank you for the heads up!

This was referenced Jun 13, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TobiGr @litetex @Stypox