Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Odia language to language selector #9651

Merged
merged 5 commits into from
Jan 15, 2023
Merged

Added Odia language to language selector #9651

merged 5 commits into from
Jan 15, 2023

Conversation

GET100PERCENT
Copy link
Contributor

@GET100PERCENT GET100PERCENT commented Jan 9, 2023 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

It adds the Odia language to the language selector.

Fixes the following issue(s)

It solves the issue #9393.

APK testing

I have downloaded and the zip file from the artifacts available in the changes section and opened the apk file inside the zip and installed it.
It works perfectly, odia language is available in the language selector in this apk file.

Due diligence

@GET100PERCENT
Copy link
Contributor Author

GET100PERCENT commented Jan 9, 2023 •
edited by github-actions bot
Loading

Screenshot_20230109-192810

Screenshot_20230109-192737

The above are Screenshots before and after the Odia language has been added to the language selector.

@opusforlife2
Copy link
Collaborator

Fill the template properly.

@opusforlife2 opusforlife2 added template ignored The user didn't follow the template/instructions (or removed them) waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. labels Jan 9, 2023
@GET100PERCENT
Copy link
Contributor Author

Fill the template properly.

Hi, i have updated the template.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 10, 2023
@SameenAhnaf SameenAhnaf added localisation / translation Everything that has to do with translations or Weblate and removed template ignored The user didn't follow the template/instructions (or removed them) labels Jan 10, 2023
@GET100PERCENT
Added Odia language to language selector
36052cc 
Added Odia language to language selector
Stypox
Stypox approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (will let @TobiGr merge)

@GET100PERCENT
Copy link
Contributor Author

Thanks! (will let @TobiGr merge)

You are welcome.

@TobiGr TobiGr self-requested a review January 13, 2023 14:25
@GET100PERCENT
Added Odia language to language selector
18166d4 
I have rendered odia and polsiki as suggested by you
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr TobiGr merged commit dba24ec into TeamNewPipe:dev Jan 15, 2023
@Stypox Stypox mentioned this pull request Jan 22, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Odia translation completed
5 participants
@GET100PERCENT @opusforlife2 @TobiGr @Stypox @SameenAhnaf