Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display channel groups as list instead of grid #9204

Closed
wants to merge 14 commits into from

Conversation

cern1710
Copy link
Contributor

@cern1710 cern1710 commented Oct 26, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Created a list view for channel groups in the subscriptions page
  • Added a toggle button to toggle between the original card view to the newly added one
  • Unlike sort, toggle button will exist at all times
  • The newly formatted buttons conforms to the same logic as the ones previously. All existing buttons work as intended as they should and will automatically update the ones on the other display format when toggled

Before/After Screenshots/Screen Record

Screenshot_20221026-205343
Screenshot_20221026-205345

Fixes the Following issue:

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@cern1710 cern1710 changed the title List view alt implementation Add option to display channel groups as list instead of grid Oct 26, 2022
@cern1710
Copy link
Contributor Author

The issue right now is it's not possible to mess with the toggle function without rewriting a big chunk of the code. These are two different entities and it's not possible to do @SetOnTouchListener and @SetOnClickListener at the same time, so you end up with a list that's merely draggable and nothing more.

@cern1710
Copy link
Contributor Author

cern1710 commented Oct 26, 2022

There is a fully working branch where I retain the old list view with a new card view, which I think is a nice implementation of the code. This newest one is quite a mess and I'm a little discouraged by it. I could rollback if you wish.

@cern1710
Copy link
Contributor Author

cern1710 commented Oct 26, 2022

image

This would be the final implementation of the list view if we do not need a toggle next to each list element

@cern1710 cern1710 marked this pull request as draft October 26, 2022 11:04
@cern1710 cern1710 closed this Oct 26, 2022
@cern1710 cern1710 deleted the list-view-alt-implementation branch October 27, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to display channel groups as list instead of grid
1 participant