Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display channel groups as list instead of grid #8605

Closed
5 tasks done
ghost opened this issue Jul 11, 2022 · 22 comments · Fixed by #9207
Closed
5 tasks done

Add option to display channel groups as list instead of grid #8605

ghost opened this issue Jul 11, 2022 · 22 comments · Fixed by #9207
Assignees
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@ghost
Copy link

ghost commented Jul 11, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

A list form of channel group instead of Grid form

Why do you want this feature?

Some users have long lengthy list of channel groups, which also make them hard to sort & also scrolling them from left to right, seems unintuitive.

Additional information

And I personally don't like manual channel group sorting & Instead prefer Alphanumeric order (might need to open another issue for this)

And also, an another problem of Grid Layout is that it masks bigger Group titles & show only first 8 of their characters on the small dpi displays.

@ghost ghost added the feature request Issue is related to a feature in the app label Jul 11, 2022
@triallax triallax changed the title [gui] list channel groups instead of grid Add option to display channel groups as list instead of grid Jul 11, 2022
@triallax triallax assigned triallax and unassigned triallax Jul 11, 2022
@triallax triallax added the GUI Issue is related to the graphical user interface label Jul 11, 2022
@plasticanu
Copy link
Contributor

Hi, we are an assignment group (6 people) studying computer science at the Australian National University. We would like to work on this issue, and we have 19 days left to write code and open a pull request. Can you assign this issue to us?

@triallax
Copy link
Contributor

@plasticanu somebody will assign you to the issue eventually, but you don't have to wait for that to happen before you actually start working on it.

@opusforlife2
Copy link
Collaborator

@plasticanu You've offered to work on a bunch of issues. Do you plan to work on any one, a few, or all of them? Please clarify so that I can start assigning.

@plasticanu
Copy link
Contributor

plasticanu commented Oct 16, 2022

@opusforlife2

Hi, sorry for the late reply. I am going to work with 2 people from my team. So we'll be a 3 people team.

@cern1710
Copy link
Contributor

Hello, I would like to also worked on this issue with @plasticanu.

@cern1710
Copy link
Contributor

cern1710 commented Oct 24, 2022

Hi! For the list layout, Is it alright if I add a toggle (the button next to sort) to change it into a vertical version of the card layout instead of completely overhauling into a list view? It would look something like this (although the layout is still very much unfinished as I need to scale the "add item" icon as well):

Screenshot_20221024-200313

@ghost
Copy link
Author

ghost commented Oct 24, 2022

@cernunnos1710 Nice work mate. So how did you implement sort function ? What are the presets ?

@cern1710
Copy link
Contributor

cern1710 commented Oct 24, 2022

Well the sort was already there so nothing had to be done with it. All I need to do now is to make the list view toggle-able (horizontal or vertical). What I'm doing is allow the user to change the channel view to either vertical or horizontal.

@opusforlife2
Copy link
Collaborator

@cernunnos1710 Looks great! Please go ahead!

BTW, does this new toggle follow the List/Grid mode setting by default? The user could always tap the toggle to change it, but the default view should respect the setting.

@cern1710
Copy link
Contributor

@opusforlife2 Yes. I did not change anything related to the card view other than those related to new layouts (some files were added because of this).

@cern1710
Copy link
Contributor

@opusforlife2 @SameenAhnaf
Screenshot_20221026-004841

Please take a look at my current implementation of card view. I am going to work on replacing the list view with the reorder dialog

@cern1710
Copy link
Contributor

Also, if I completed my implementation of the list view (given that the change would not be major if at all, UI wise) , would it be okay to create a PR?

@opusforlife2
Copy link
Collaborator

Potential problem: if a user switched to list mode and has several channel groups, their subscriptions could be pushed down very far, needing a lot of scrolling.

I'm thinking maybe channel groups should have their own tab beside Subscriptions? Then it would be easier to have list/grid modes separately for channels and channel groups, without inconveniencing the user.

@cern1710
Copy link
Contributor

cern1710 commented Oct 25, 2022

My implementation of the list view would likely be a copy of what FeedGroupReorderDialog's list look like, which is quite small. Then there's the potential problem where you have two more empty views to scroll through before reaching bookmarked playlists.

I also think it would be a bit weird since you're adding subscribed channels to channel groups, where both are directly related.

@opusforlife2
Copy link
Collaborator

Alright. The separate tab discussion can happen later. Please go ahead.

replacing the list view with the reorder dialog

What does this mean?

@cern1710
Copy link
Contributor

My bad. I meant replacing the list layout for channels to the one in reorder dialog where you can drag each item.

@plasticanu
Copy link
Contributor

I think you should keep the list size from the reorder dialog list view, but add a gray color background to the text as you did in the earlier PR. @cernunnos1710

@cern1710
Copy link
Contributor

I will see what I can do.

@Stypox
Copy link
Member

Stypox commented Oct 25, 2022

@cernunnos1710 please open a PR when you have completed the implementation. Other details such as "where to put each button" and "which color to give to what" can be discussed later.

@cern1710
Copy link
Contributor

cern1710 commented Oct 26, 2022

@opusforlife2 I have an issue where when I add the toggle button, I can no longer click on the actual page, which would make it a lot less interactive. The list view would only serve as a toggle feature which doesn't make a lot of sense to me.

@Stypox
Copy link
Member

Stypox commented Oct 26, 2022

(if you open the PR I can take a look at the code ;-))

@cern1710
Copy link
Contributor

@Stypox Opened the PR! :)

(I might have opened the wrong one though since I submitted the one that is highly problematic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
5 participants