Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to display channel groups as list instead of grid #9194

Closed
wants to merge 10 commits into from

Conversation

cern1710
Copy link
Contributor

@cern1710 cern1710 commented Oct 25, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Created a list view for channel groups in the subscriptions page
  • Added a toggle button to toggle between the original card view to the newly added one
  • Unlike sort, toggle button will exist at all times
  • The newly formatted buttons conforms to the same logic as the ones previously. All existing buttons work as intended as they should and will automatically update the ones on the other display format when toggled

Before/After Screenshots/Screen Record

  • Before:
    Screenshot_20221025-115648-2

  • After:
    Screenshot_20221025-114840
    Screenshot_20221025-114829

Fixes the Following issue:

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@cern1710
Copy link
Contributor Author

Depending on the maintainers' decision, this could also fix #8913.

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Oct 25, 2022

For list view, include position holder on the right of group names. There's no need of separate option for rearranging positions.

IMG_20221025_170104

For grid view, limit 3 groups for every line like YouTube app layout. Instead of squishing name into a single box, use marquee option.

IMG_20221025_164612

For both list and grid view, replace Rearrange icon on the right of top bar with + New icon in the end. (See first screenshot for reference).

@cern1710
Copy link
Contributor Author

@SameenAhnaf I will fix this ASAP. Thanks for the response.

@cern1710 cern1710 deleted the branch TeamNewPipe:dev October 25, 2022 11:56
@cern1710 cern1710 closed this Oct 25, 2022
@cern1710 cern1710 deleted the dev branch October 25, 2022 11:56
@opusforlife2
Copy link
Collaborator

@cernunnos1710 Why did you delete the branch and close the PR?

When discussing UI changes, it is better to try things out in your local repo and then post screenshots directly. If you go to all the effort of opening another PR, and yet more changes are suggested, then that means your time is wasted.

@cern1710
Copy link
Contributor Author

cern1710 commented Oct 25, 2022

Oops! I accidentally deleted this PR. I wanted to create a new branch which is why I deleted this branch, sorry. Should I create a new PR?

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Oct 25, 2022

You can post your latest screenshots in the issue itself before opening any PR. It will mean less effort on your part.

Edit: creating a new branch is okay. If you check our contributor guidelines, we do advise to name your branch something relevant.

@cern1710
Copy link
Contributor Author

Okay understood. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to display channel groups as list instead of grid
3 participants