-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to display channel groups as list instead of grid #9194
Conversation
…ticalItem in line 26
…ing on refreshing
…s in SubscriptionFragment.kt
Depending on the maintainers' decision, this could also fix #8913. |
For list view, include position holder on the right of group names. There's no need of separate option for rearranging positions. For grid view, limit 3 groups for every line like YouTube app layout. Instead of squishing name into a single box, use marquee option. For both list and grid view, replace |
@SameenAhnaf I will fix this ASAP. Thanks for the response. |
@cernunnos1710 Why did you delete the branch and close the PR? When discussing UI changes, it is better to try things out in your local repo and then post screenshots directly. If you go to all the effort of opening another PR, and yet more changes are suggested, then that means your time is wasted. |
Oops! I accidentally deleted this PR. I wanted to create a new branch which is why I deleted this branch, sorry. Should I create a new PR? |
You can post your latest screenshots in the issue itself before opening any PR. It will mean less effort on your part. Edit: creating a new branch is okay. If you check our contributor guidelines, we do advise to name your branch something relevant. |
Okay understood. Thanks! |
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
After:
Fixes the Following issue:
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence