Remove pin and notifications night icons #8081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were added by accident in PRs not properly rebased on top of TeamNewPipe#7518, they can be removed safely.
|
Kudos, SonarCloud Quality Gate passed!
|
Koitharu
approved these changes
Mar 20, 2022
litetex
approved these changes
Mar 20, 2022
TacoTheDank
added
the
codequality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were added by accident in PRs not properly rebased on top of #7518, they can be removed safely.
What is it?
Description of the changes in your PR
See the last line of #2335 (review). PRs #2335 and #7577 were not properly rebased on top of #7518 (or viceversa), causing two night icons to be added accidentally even though after #7518 we don't need them anymore.
APK testing
I checked both the pin and the notifications icons in all three themes and the icons are themed correctly.
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence