Remove icon duplicates and fix some theming issues

[mauriciocolli]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Some icons are not consistently themed (it affects the other pull request #7516):

---

• Remove unnecessary duplicates of some icons, as it is a bad practice that leads to mistakes. As vectors are used, color resources are available.
  • The documentation recommends the ?colorControlNormal attribute. It's the default value when creating a new vector drawable.
    I chose the night-qualified resources route to stay consistent with current behavior. Do share your thoughts on this.
  • Take a look at the "live tv" icon, it was left at the default value (?colorControlNormal), so it's already using the attribute and its color is different than the rest.
• Use menu resources instead of manually creating it, let the system do its job and get the correct resources.
  • Some menu items were not themed properly because the toolbar itself had a custom theme overriding some values.

---

Now only some drawables are different in behavior than the rest of the ic_ prefixed icons:

• The heart icon.
• Headphone with shadow.
• Play with shadow.

Do you think they should be renamed to something else to make it consistent?

Due diligence

• I read the contribution guidelines.

[Stypox]

Woah, the APK size is reduced by 300kb :-D
Great work, I will review and give feedback soon. I tried other times, too, but never found out how to properly style icons on Android without creating duplicates everywhere or having to write Java code for each icon. Just one thing: does this work well in all situations on API 19 too?

[mauriciocolli]

Just one thing: does this work well in all situations on API 19 too?

I think so, the app is currently using the support library for vectors and the proper build configuration is already set.

Also, the test icon preview in the original post was working in every API I tested (19,23,26,28,30,31,32-preview). Both using it in layouts (normal layouts, menu, drawer) and getting the drawable with AppCompatResources.getDrawable.

I think that should cover all uses, right?

[litetex]

@mauriciocolli
How did you get the view with all icons? (in the PR-description)

[litetex]

LGTM
Tested it in my emulator (Android 11) and didn't saw any specific problems.

[Stypox]

Code looks good. I could only find one issue after testing anything that came to my mind in both white and dark theme on API 19:

• on white theme the icon on top of local and remote playlist items is black instead of white
  

[TacoTheDank]

This is fantastic work. Thanks so much! 💟

[litetex]

Note: This PR might be affected by #7577 and vice versa.

[Stypox]

I rebased and pushed a commit that fixes the issue I reported above. I tested again various miscellaneous things on API 19, on API 22, and on my API 29 phone, and I found no issue. Ready for merge in my opinion. @litetex

I think the only possible regressions this PR could introduce are in places that retain the same color under all themes (the playlist icon is an example of this). Therefore I tested well the player (which behaves that way), but could not think of other places where the color of an icon should be independent of theme (except for the already mentioned&fixed playlist icon). So I think we are safe to merge this PR as there should be no regressions, and even if there are, they will not be much impacting.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication