Dismiss download dialog correctly

[Stypox]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

The first commit just reorders some methods in the DownloadDialog class and adds some comment section separators.
The second commit fixes the DownloadDialog (which is a DialogFragment) dismissing according to this thread: every reference to getDialog().dismiss() is replaced with just dismiss(). I also removed references to getDialog().setOnDismissListener() and replaced them with a new onDismissListener in DownloadDialog, required by RouterActivity to be able to finish() itself when the dialog dismisses. Then I removed the part of code that used to finish() the RouterActivity inside the DownloadDialog (it was in the wrong place), as that's now done correctly by the listener.

Fixes the following issue(s)

Fixes #6667
Fixes #6256

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
@Pass1Vlax @khumarahn @skyGtm @TacoTheDank could you tell me if this works for you?

Due diligence

• I read the contribution guidelines.

[ghost]

I can't find the options in check, can you please send me a direct link?

[khumarahn]

@Pass1Vlax look for "artifacts".

I installed the new version. Was able to download a youtube video without problems.

[skyGtm]

Works good for both SAF enabled or disabled case.

[skyGtm]

Might fix these issues:
#6687
#6665
#6256

[Stypox]

@Pass1Vlax direct link

[ghost]

@Pass1Vlax direct link

It works, Good job!

[TobiGr]

Looks good to me

[TacoTheDank]

Works! You're the best! :P

[khumarahn]

Thanks! Is it reasonable to ask for a bugfix release for this issue? It seems quite essential.

[ghost]

Thanks! Is it reasonable to ask for a bugfix release for this issue? It seems quite essential.

I agree, it would help a lot of people that use this option

[pixel2user]

Thanks! Is it reasonable to ask for a bugfix release for this issue? It seems quite essential.

@TeamNewPipe - Please release this fix as a hotfix-release on F-Droid. The bug makes NewPipe unusable on Android 10 and 11! :-(

https://github.com/TeamNewPipe/NewPipe/actions/runs/1049264498