Crashing when downloading because of SAF #6687

castrik · 2021-07-17T07:50:42Z

Checklist

I am using the latest version - x.xx.x
I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

download any video or go to see download folder in the app, app restarts a couple of time and crashes

happening only if I enable SAF, its default in 0.21.6 also happens in 0.21.5 if I enabled it

but in 0.21.5, I could atleast see my downloads folder, in 0.21.6 it crashes in both cases, seeing the downloads folder or downloading a video/audio

Actual behavior

Expected behavior

Screenshots/Screen recordings

Screen_Recording_20210717-131612_NewPipe.mp4

Logs

`## Exception

User Action: ui error
Request: ACRA report
Content Country: US
Content Language: en-US
App Language: en_US
Service: none
Version: 0.21.6
OS: Linux Android 10 - 29

Crash log

java.lang.RuntimeException: Unable to create service us.shandian.giga.service.DownloadManagerService: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4412)
	at android.app.ActivityThread.access$1800(ActivityThread.java:274)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2118)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loop(Looper.java:237)
	at android.app.ActivityThread.main(ActivityThread.java:8167)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at us.shandian.giga.service.DownloadManager.loadPendingMissions(DownloadManager.java:165)
	at us.shandian.giga.service.DownloadManager.<init>(DownloadManager.java:77)
	at us.shandian.giga.service.DownloadManagerService.onCreate(DownloadManagerService.java:142)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4400)
	... 8 more

`

Device info

Android version/Custom ROM version:
Device model:

The text was updated successfully, but these errors were encountered:

bew · 2021-07-17T11:25:13Z

I have the same crash & behavior.
What is SAF ?

castrik · 2021-07-17T16:22:36Z

What is SAF ?

read the blog post of the update release
https://newpipe.net/blog/pinned/release/newpipe-0.21.6-released/

bew · 2021-07-17T19:57:09Z

Thanks! I tried to disable SAF, but I still get the same error:

Exception

User Action: ui error
Request: ACRA report
Content Country: GB
Content Language: en
App Language: en_US
Service: none
Version: 0.21.6
OS: Linux Android 9 - 28

Crash log

java.lang.RuntimeException: Unable to create service us.shandian.giga.service.DownloadManagerService: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:3579)
	at android.app.ActivityThread.access$1300(ActivityThread.java:197)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1669)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6671)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:495)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:860)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at us.shandian.giga.service.DownloadManager.loadPendingMissions(DownloadManager.java:165)
	at us.shandian.giga.service.DownloadManager.<init>(DownloadManager.java:77)
	at us.shandian.giga.service.DownloadManagerService.onCreate(DownloadManagerService.java:142)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:3567)
	... 8 more

timjefferies · 2021-07-18T06:09:17Z

Same issue for me. I'm on Android 11 so no option to disable.

`## Exception

User Action: ui error
Request: ACRA report
Content Country: GB
Content Language: en-GB
App Language: en
Service: none
Version: 0.21.6
OS: Linux Android 11 - 30

Crash log

java.lang.RuntimeException: Unable to create service us.shandian.giga.service.DownloadManagerService: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4198)
	at android.app.ActivityThread.access$1500(ActivityThread.java:237)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1932)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7660)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at us.shandian.giga.service.DownloadManager.loadPendingMissions(DownloadManager.java:165)
	at us.shandian.giga.service.DownloadManager.<init>(DownloadManager.java:77)
	at us.shandian.giga.service.DownloadManagerService.onCreate(DownloadManagerService.java:142)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4186)
	... 8 more

`

skyGtm · 2021-07-19T13:30:51Z

It seems to have fixed.
You guys should try debug apk from this PR. #6701

Stypox · 2021-07-19T19:27:24Z

@skyGtm again, that PR is unrelated ;-)

timjefferies · 2021-07-21T02:03:50Z

Issue remains on version 0.21.7

`## Exception

User Action: ui error
Request: ACRA report
Content Country: GB
Content Language: en-GB
App Language: en
Service: none
Version: 0.21.7
OS: Linux Android 11 - 30

Crash log

java.lang.RuntimeException: Unable to create service us.shandian.giga.service.DownloadManagerService: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4198)
	at android.app.ActivityThread.access$1500(ActivityThread.java:237)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1932)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:223)
	at android.app.ActivityThread.main(ActivityThread.java:7660)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String org.schabi.newpipe.streams.io.StoredFileHelper.toString()' on a null object reference
	at us.shandian.giga.service.DownloadManager.loadPendingMissions(DownloadManager.java:165)
	at us.shandian.giga.service.DownloadManager.<init>(DownloadManager.java:77)
	at us.shandian.giga.service.DownloadManagerService.onCreate(DownloadManagerService.java:142)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4186)
	... 8 more

`

Stypox · 2021-07-21T08:56:41Z

@timjefferies @bew @castrik does #6721 fix the problem for you?

castrik · 2021-07-21T12:30:02Z

@timjefferies @bew @castrik does #6721 fix the problem for you?

thank you, works flawlessly now

massyas · 2021-07-22T12:37:02Z

Hello,
I also have the same issue on Android 10 (Oxygen OS 10.3.11 on OnePlus 6) and even with version 0.21.7 crash is still there.
I tried to reset the download folder once SAF has been enabled by default but without success.

TobiGr · 2021-07-22T13:13:10Z

@massyas Did you test the APK from #6721?

massyas · 2021-07-22T13:52:50Z

Hello @TobiGr
My mistake, I thought the fix was already integrated in 0.21.7
It works perfect with debug APK from #6721
Thanks !

massyas · 2021-07-23T21:42:10Z

Hello @TobiGr
Unfortunately the problem has reappeared at my side on the debug version with a different stack apparently but same consequence

java.lang.RuntimeException: Unable to create service us.shandian.giga.service.DownloadManagerService: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.io.File.exists()' on a null object reference
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4082)
	at android.app.ActivityThread.access$1800(ActivityThread.java:231)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1968)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7682)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:516)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean java.io.File.exists()' on a null object reference
	at org.schabi.newpipe.streams.io.StoredFileHelper.existsAsFile(StoredFileHelper.java:295)
	at us.shandian.giga.get.DownloadMission.hasInvalidStorage(DownloadMission.java:667)
	at us.shandian.giga.service.DownloadManager.loadPendingMissions(DownloadManager.java:152)
	at us.shandian.giga.service.DownloadManager.<init>(DownloadManager.java:77)
	at us.shandian.giga.service.DownloadManagerService.onCreate(DownloadManagerService.java:142)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4070)

Hope this can help...

Stypox · 2021-07-27T09:39:52Z

@massyas could you test #6778?

massyas · 2021-07-27T15:41:45Z

@massyas could you test #6778?

Hello @Stypox , #6778 apk seems to work ok. I set the same download folder as before and tried to download several videos with success.
Thanks 👍

Stypox · 2021-08-04T07:23:36Z

@Movisivi please provide a crash report

subsonik · 2021-08-04T07:26:47Z

I'm having the same issue.

When "Ask where to download" is enabled, I click Download, select Audio/Video, click OK, the file chooser pops up (MiXplorer in my case), I select a folder, but then NewPipe says "Action denied by the system". The "Files and media" permission is granted.

If "Ask where to download" is disabled and I try to select a "Video/Audio download folder", the app just exits without error.

Stypox · 2021-08-04T08:11:22Z

@subsonik do other apps using SAF work on your system?

Stypox · 2021-08-04T10:28:45Z

I thought this fix was included in this last release, was it not?

No, it wasn't, 0.21.8 was a hotfix release for youtube, just look at the release notes. You can test 0.21.9 though: #6841

castrik added the bug Issue is related to a bug label Jul 17, 2021

triallax added downloader Issue is related to the downloader more info needed labels Jul 17, 2021

skyGtm mentioned this issue Jul 19, 2021

Dismiss download dialog correctly #6701

Merged

5 tasks

bew mentioned this issue Jul 20, 2021

Downloading bug #6713

Closed

Stypox mentioned this issue Jul 21, 2021

Delete pending missions with invalid storage #6721

Merged

5 tasks

TobiGr closed this as completed in #6721 Jul 22, 2021

This was referenced Jul 23, 2021

Application get crash with downloads #6729

Closed

Crash on download #6738

Closed

bew mentioned this issue Jul 25, 2021

When I press download button, Newpipe crashes #6761

Closed

This was referenced Jul 25, 2021

Can't download videos #6766

Closed

App crash when opening the list of downloads #6767

Closed

Help #6768

Closed

bew mentioned this issue Jul 27, 2021

Crash on pressing Download button or Download tab #6775

Closed

4 tasks

Stypox mentioned this issue Jul 27, 2021

Fix NullPointerException when checking if storage exists #6778

Merged

5 tasks

triallax mentioned this issue Jul 30, 2021

Crashed when opening after installing latest update #6805

Closed

4 tasks

ghost mentioned this issue Jul 30, 2021

UI crashes on download related actions on Android 11 #6806

Closed

4 tasks

triallax mentioned this issue Aug 1, 2021

Can't Download anything or open Downloads it crashes the app instantly #6823

Closed

This comment has been minimized.

Sign in to view

litetex mentioned this issue Aug 8, 2021

Error when downloading #6875

Closed

triallax mentioned this issue Aug 8, 2021

Repeatedly crashing with specific app data stored (IllegalArgumentException) #6797

Closed

4 tasks

mpsq mentioned this issue Aug 9, 2021

Cannot download an any video #6881

Closed

4 tasks

triallax mentioned this issue Aug 19, 2021

UI crashing if i tap download tab #6943

Closed

triallax mentioned this issue Sep 2, 2021

NewPipe doesn't work properly on HUAWEI P20 Pro #6836

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crashing when downloading because of SAF #6687

Crashing when downloading because of SAF #6687

castrik commented Jul 17, 2021

bew commented Jul 17, 2021

castrik commented Jul 17, 2021

bew commented Jul 17, 2021

timjefferies commented Jul 18, 2021

skyGtm commented Jul 19, 2021

Stypox commented Jul 19, 2021

timjefferies commented Jul 21, 2021

Stypox commented Jul 21, 2021

castrik commented Jul 21, 2021

massyas commented Jul 22, 2021

TobiGr commented Jul 22, 2021

massyas commented Jul 22, 2021

massyas commented Jul 23, 2021 •

edited

Loading

Stypox commented Jul 27, 2021

massyas commented Jul 27, 2021

Stypox commented Aug 4, 2021

subsonik commented Aug 4, 2021

Stypox commented Aug 4, 2021

This comment has been minimized.

Stypox commented Aug 4, 2021 •

edited

Loading

Crashing when downloading because of SAF #6687

Crashing when downloading because of SAF #6687

Comments

castrik commented Jul 17, 2021

Checklist

Steps to reproduce the bug

Actual behavior

Expected behavior

Screenshots/Screen recordings

Logs

Device info

bew commented Jul 17, 2021

castrik commented Jul 17, 2021

bew commented Jul 17, 2021

Exception

timjefferies commented Jul 18, 2021

skyGtm commented Jul 19, 2021

Stypox commented Jul 19, 2021

timjefferies commented Jul 21, 2021

Stypox commented Jul 21, 2021

castrik commented Jul 21, 2021

massyas commented Jul 22, 2021

TobiGr commented Jul 22, 2021

massyas commented Jul 22, 2021

massyas commented Jul 23, 2021 • edited Loading

Stypox commented Jul 27, 2021

massyas commented Jul 27, 2021

Stypox commented Aug 4, 2021

subsonik commented Aug 4, 2021

Stypox commented Aug 4, 2021

This comment has been minimized.

Stypox commented Aug 4, 2021 • edited Loading

massyas commented Jul 23, 2021 •

edited

Loading

Stypox commented Aug 4, 2021 •

edited

Loading