-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide 5, 15, 25 second seek options if inexact seek is enabled #3160
Conversation
Works as expected. 👍 |
I think it should be rounded up instead of always being set to 10:
Also, would it be possible to add a description to "Fast-forward/-rewind seek duration", too, so that the user knows why 5,15,25 seek durations are not available? |
Can be done.
The description field is already used to display the selected value.
I would do this then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, apart from an issue with strings. Thank you for implementing the suggestions :-D
Could you provide an updated debug apk, please?
app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettingsFragment.java
Show resolved
Hide resolved
app/src/main/res/values/strings.xml
Outdated
@@ -593,6 +593,7 @@ | |||
<string name="app_language_title">App language</string> | |||
<string name="systems_language">System default</string> | |||
<string name="dynamic_seek_duration_description">%s seconds</string> | |||
<string name="new_seek_duration_toast">Due to ExoPlayer contraints the seek duration was set to</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this have a %s
indicating where the "X seconds" string should be inserted? For English it is ok for this to be at the end, but for other languages this could be different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, didn't think of other languages having a different arrangement
I'll update the apk tomorrow, I'm on mobile now. |
No problem, thank you for the time you are putting into contributing ;-) |
…when opening settings
Reset to 10 seconds when previous value is not valid anymore
@Stypox I updated the apk and rebased the branch onto dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready, thank you! If you agree with the last change I suggested, just click on "Commit suggestion" directly from github/mobile and I will merge this.
app/src/main/java/org/schabi/newpipe/settings/VideoAudioSettingsFragment.java
Outdated
Show resolved
Hide resolved
…gsFragment.java Co-Authored-By: Stypox <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, thank you :-D
closes #3127
Hides 5, 15, 25 second seek options if inexact seek is enabled. If one of those values was selected while activating inexact seek, it automatically gets set to 10 seconds.
Will the edited string resource make any problems concerning translation with weblate, since it was not a rewrite but adding additional info.
I tested it on my Android 10 and 7.1 devices.
Updated apk: app-debug.zip