Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Seek duration of 5 seconds makes audio rewind impossible #3127

Closed
1 task done
opusforlife2 opened this issue Feb 22, 2020 · 12 comments · Fixed by #3160
Closed
1 task done

[Bug] Seek duration of 5 seconds makes audio rewind impossible #3127

opusforlife2 opened this issue Feb 22, 2020 · 12 comments · Fixed by #3160
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)

Comments

@opusforlife2
Copy link
Collaborator

  • I checked if the issue/feature exists in the latest version.

  • Set the seek duration to 5 seconds.

  • Play an audio till 30 seconds or so.

  • Try rewinding.

It will do so once until the timestamp is a multiple of 10 seconds. Then tapping rewind just keeps taking you to that timestamp, not allowing you to go further back.

If you rapidly jam the rewind button, though, you overcome this 'barrier' of sorts and get taken quite far back.

This issue exists only for the 5 second duration.

@Stypox Stypox added bug Issue is related to a bug player Issues related to any player (main, popup and background) labels Feb 22, 2020
@Stypox
Copy link
Member

Stypox commented Feb 22, 2020

@XiangRongLin could you look into this? ;-)

@XiangRongLin
Copy link
Collaborator

@Stypox Will do

@XiangRongLin
Copy link
Collaborator

@opusforlife2 Could it be that you have "Use fast inexact seek" on?

@opusforlife2
Copy link
Collaborator Author

opusforlife2 commented Feb 22, 2020

@XiangRongLin Yep. I should have noted that as a relevant detail. My bad.

@XiangRongLin
Copy link
Collaborator

If i understood it correctly, this is just the way exo player works when using inexact seek.
According to this article (https://medium.com/@takusemba/deep-understanding-of-seek-4e10079165ec), it just seeks to the closes sync point with the current config here, which appears to be every 10 seconds. So if you want to rewind 5 seconds the closest sync point is the current one. You can also notice it when seeking forward. Although the setting is 5 second, the next closes point is 10 seconds away.

If you use 15 or 25 seconds you will also notice that the left over 5 seconds gets ignored.

@opusforlife2
Copy link
Collaborator Author

I was guessing it would be something like that.
It does indeed ignore anything modulo 10. Good find.

Why is it that it only happens with audio, though? This works perfectly well for videos.

@XiangRongLin
Copy link
Collaborator

My guess would be that the sync points are different. Like the article mentioned those sync points depend on your media type and streaming protocol

@opusforlife2
Copy link
Collaborator Author

Strange. The article mentioned streaming protocol and container format. They should both be the same for audios as well as videos + audios.

@opusforlife2
Copy link
Collaborator Author

@XiangRongLin I've seen comments (regarding resolutions) that certain list options can be hidden if a preference is toggled. Can the same be done with inexact seek? If it is on, the options 5, 15 and 25 should be hidden.

@XiangRongLin
Copy link
Collaborator

This idea should work.
The inexact seek description would need to be extended to include this Information.

What should then happen if the setting is at 5/15/25 and the user activates inexact seek? Automatically set it back to 10?

@opusforlife2
Copy link
Collaborator Author

opusforlife2 commented Feb 29, 2020

Yes. And the inexact seek description should say that it only allows 10, 20 and 30 second options. No need to explain why that is, though.

Edit: or maybe a simple 'Exoplayer limitation' in brackets?

@XiangRongLin
Copy link
Collaborator

@opusforlife2 PR is open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants