Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.17.0 #2482

Merged
merged 118 commits into from
Aug 12, 2019
Merged

Release v0.17.0 #2482

merged 118 commits into from
Aug 12, 2019

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jul 31, 2019

New

Playback resume #2288

  • Resume streams where you stopped last time

Downloader Enhancements #2149

  • Use Storage Access Framework to store downloads on external SD-cards
  • New mp4 muxer
  • Optionally change the download directory before starting a download
  • Respect metered networks

Improved


Fixed


Blockers

  • Slow download speed of audio streams

  • Database import fails

  • History loading is slow


Corresponding issue: #2483
Corresponding PR for the extractor: TeamNewPipe/NewPipeExtractor#179

APKs for testing and finding bugs

are available in the corresponding issue:

Please report all new bugs which are related to one of the changes above in #2483

yausername and others added 30 commits March 11, 2019 03:08
Add supported services section
Move comment support
Also made the code that creates the menus consistent across files.
VideoDetailFragment already borrows a consistant menu from the stream list it holds.
Currently translated at 90.3% (400 of 443 strings)
Currently translated at 90.3% (400 of 443 strings)
They were exactly the same as the base class function
Inverted unsubscribe with share, since share has always been put after content-specific actions.
start_here_on_background has the same meaning

start_here_on_main is now unused, but I left it there so that if it ever becomes useful again, it is ready to be used.
Currently translated at 99.8% (442 of 443 strings)
Currently translated at 58.9% (261 of 443 strings)
@TobiGr
Copy link
Contributor Author

TobiGr commented Jul 31, 2019

I've been using the new version for quite some time now and couldn't find any blocking bugs. @theScrabi is going to upload an offically signed apk soon. As I didn't encountered any new bugs and hopefully you won't either, I'd like to release 0.17.0 after a short testing period at the end of this week or at the beginning of the next week.

app/build.gradle Outdated Show resolved Hide resolved
@TobiGr
Copy link
Contributor Author

TobiGr commented Jul 31, 2019

I'd also open an issue for this, as I think people read more issues than pull requests.

I wanted to do this as soon as there are apks for testing.

@theScrabi
Copy link
Member

I quickly removed that last commit and rebuild the app.

fast

@TobiGr TobiGr force-pushed the release_v0.17.0 branch 3 times, most recently from 8b9a10c to 9e9ccda Compare July 31, 2019 23:50
@TobiGr TobiGr mentioned this pull request Aug 1, 2019
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the string direct_on_background in #2368 since it was a duplicate of start_here_on_background. Now it has been translated to more languages, so it should be also removed from them. Or does WebLate do this automatically as soon as this pr is merged?

* fix socket leak in "DownloadRunnable"
* in "DownloadInitializer" close the HTTP body after doing range-request checks
* in "DownloadRunnableFallback" fix typo in comment
* in "DownloadDialog" fix regression, using one thread for audios instead of subtitles
@TobiGr
Copy link
Contributor Author

TobiGr commented Aug 2, 2019

Or does WebLate do this automatically as soon as this pr is merged?

@Stypox Yes, but I don't wan't to have these unused strings in the release APK. I removed the left over gema strings during the merge, but forgot direct_on_background . I'll remove them later today.

@theScrabi theScrabi merged commit f98e5cc into master Aug 12, 2019
@TobiGr TobiGr deleted the release_v0.17.0 branch August 12, 2019 11:34
@snappyapple632
Copy link

snappyapple632 commented Aug 12, 2019

Hmm... If MP4 support is going to be added, I think it would also be a good time to address #507 in a future update, since MP4 is essentially MP3 + video. I'm sure the MP4 muxer could be modified to also serve as an MP3 muxer. This would allow for a much more efficient implementation of MP3 download support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.