-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence CheckForNewAppVersionTask #2423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you please print the exception to the log when debug is enabled?
Can you please do the same in line 119 to close #2197 as well? |
I think a Toast or a Snackbar should be shown in these cases, just to let the user know. Maybe with |
like this @Stypox ? |
Yes, that's not intrusive |
Good, idea @Stypox. I think in this case it might be better to not show |
Both "can not" and "cannot" are accepted by english, afaik
|
In my opinion the user should not be notified about this. This is just an app update check. It probably happens often so if it fails every now and then it's not a big deal. imo it should be hidden from the user since the user is usually not aware of this anyway so when they see an error it will just confuse them since no action on the users side is needed. edit: for example the user might be reading some comment and this is when his reception changes in this moment the update check fails but the user is busy with reading comments and the reception might be better already when he is done reading, no need to notify him about a failed background update check. |
Well we should still get notifications when something failes, however if its a simple SSL issue because the host could not be reached I would not send a notification at all just as you said. |
okay, I have removed the Toast messages again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Closes #2421
Closes #2197
This is a very simple change to not annoy users when the internet connection isn't stable. The task will run again on another occasion.