-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] change list_stream_item layout and item height #1297
Conversation
Thanks for the pull request! I think increasing the size it's not the ideal solution here, it's way too big now (though I can be biased because I'm used to the current size). |
Well, this is a simple way. I think an extra item size option would be better. We can discuss in that issue |
I agree with @mauriciocolli, this solution would only alleviate the problem but doesn't solve it since once you increase the font size through the system settings, this problem will come up again. The official youtube app seems to solve this by increasing the item size when the font size is increased. But since we are not doing anything when the font size is nonstandard (we might want to later, with autosizing text views), the easiest solution off my mind is just add @DanteAndroid |
@karyogamy 我是用的weblate,顺手把repository也提交了一下。没想到竟然会出现在我的Pull request里,不太熟悉PR。另外那个问题似乎是跟字体有关,因为字体大小我用的默认的。 |
@DanteAndroid It's better to use English for development though, I was just giving a reminder, since we can't accept the PR with translations mixed in =D But yeah, the font you are using is nonstandard, as the item UI is probably developed under Android Studio's default. So for now, the easiest way to fix this is to just restrict the size of the title textview, unless you want to attempt a proper solution with autosizing or have better ideas. |
madre mia, no se de qué hablais :D
o nosotros usamos un layout de responsiv Ich dachte ja eh schon länger mal daran ein extra Items Layout für Tablets ein zu führen. |
|
@theScrabi se dice "madre mia, no se de qué hablais" 😅 |
@speednroll fixed. gracias :D |
@DanteAndroid So i finally tested this commit, and I think a bigger thumbnail size wouldn't fix the problem. I know In Qt there is a way to figure out the text size before the text is even rendered. Maybe we can use this to dynamically change the size of the thumbnail according to the size of the font. |
See #1292