Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List item display overlaps #1292

Closed
DanteAndroid opened this issue Apr 9, 2018 · 7 comments · Fixed by #5813
Closed

List item display overlaps #1292

DanteAndroid opened this issue Apr 9, 2018 · 7 comments · Fixed by #5813
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@DanteAndroid
Copy link

DanteAndroid commented Apr 9, 2018

Model: Samsung N9500
Screen display: Medium scale, medium font

Actually, I think the list_stream_item height is a little low, so I just change it to 110dp, just look fine.
My suggestion is:

  1. Change the layout to a better one (which I'm not sure, maybe constraintlayout?)
  2. Add an option of having a large item view which could bypass this issue (Youtube client has a way bigger item)

FYI:

Before/after

Before: 
    <!-- Elements Size -->
    <!-- 16 / 9 ratio-->
    <dimen name="video_item_search_thumbnail_image_width">124dp</dimen>
    <dimen name="video_item_search_thumbnail_image_height">70dp</dimen>
    <!-- Calculated: 2*video_item_search_padding + video_item_search_thumbnail_image_height -->
    <dimen name="video_item_search_height">94dp</dimen>
After: 
    <!-- Elements Size -->
    <!-- 16 / 9 ratio-->
    <dimen name="video_item_search_thumbnail_image_width">150dp</dimen>
    <dimen name="video_item_search_thumbnail_image_height">86dp</dimen>
    <!-- Calculated: 2*video_item_search_padding + video_item_search_thumbnail_image_height -->
    <dimen name="video_item_search_height">110dp</dimen>
@theScrabi
Copy link
Member

Yea ... you are not the first who requested a change here.
Seems you already figured out a loot. Would you like to send us a pull request with the fix :)

@theScrabi theScrabi added the bug Issue is related to a bug label Apr 9, 2018
@mauriciocolli
Copy link
Contributor

It seems like your font is causing this, can you please try with the default android font?

@DanteAndroid
Copy link
Author

Yeah, I just tried it works fine with the default font. But hey, I really hate the default. LOL

@theScrabi
Copy link
Member

It seems like your font is causing this, can you please try with the default android font?

This is actually something I witness multiple people to have problems with. So one college at my work for example has a xiomi phone with a larger than default font, he has similar problems.

@ghost
Copy link

ghost commented Apr 12, 2018

this is related to #1008

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@TobiGr TobiGr removed the stale label Jul 19, 2019
@Stypox Stypox added the GUI Issue is related to the graphical user interface label Jul 19, 2019
@TobiGr
Copy link
Contributor

TobiGr commented Mar 12, 2021

Please test #5813

@TobiGr TobiGr linked a pull request Mar 12, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants