Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write permission to PR labeler workflow #10447

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Add write permission to PR labeler workflow #10447

merged 1 commit into from
Sep 24, 2023

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Sep 24, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This updated the workflow which labels PRs depending on the size of the change set. Te workflow was introduced in #10170. The write permission for the workflow was missing. From the docs:

Work with pull requests. For example, pull-requests: write permits an action to add a label to a pull request. For more information, see "Permissions required for GitHub Apps."

The permissions on my fork are different. I fixed that to prevent such issues in the future.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added the meta Related to the project but not strictly to code label Sep 24, 2023
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Sep 24, 2023
@TobiGr TobiGr merged commit f90d74c into dev Sep 24, 2023
4 of 8 checks passed
@TobiGr TobiGr deleted the pr-labeler branch September 24, 2023 18:28
This was referenced Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant