Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow "PR size labeler" to label PRs based on the number of changed lines #10170

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Jun 17, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Add a workflow to label PRs based on the number of changed lines. This should help reviewers to determine which PRs to review.

Current configuration:

  • small: < 50 changed lines
  • medium: 50 - 249 changed lines
  • large: > 250 changed lines

I was thinking about adding a two more categories for 250 - 500 and > 500 changed lines. Wdyt?

Before/After Screenshots/Screen Record

For a live demo, see TobiGr#12, TobiGr#13, TobiGr#14
grafik

Due diligence

@TobiGr TobiGr added the meta Related to the project but not strictly to code label Jun 17, 2023
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add "size/giant" for PRs with over 750 lines? Multiple images, channel tabs, multiple audio tracks, comment replies all fit in this category

@TobiGr TobiGr force-pushed the actions/pr-size-labeler branch 2 times, most recently from 8f13f55 to 5d57b59 Compare September 23, 2023 13:18
…anged lines

This should help reviewers to determine which PRs to review.
@Stypox Stypox merged commit 2d4f56f into dev Sep 24, 2023
6 of 7 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TobiGr TobiGr deleted the actions/pr-size-labeler branch September 24, 2023 10:05
This was referenced Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants