Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver break from 0.2.16 to 0.2.17 #200

Closed
vi opened this issue Jun 10, 2019 · 4 comments
Closed

Semver break from 0.2.16 to 0.2.17 #200

vi opened this issue Jun 10, 2019 · 4 comments
Labels
bug This is a BUG. The fix may be released in a patch version even if considered breaking

Comments

@vi
Copy link

vi commented Jun 10, 2019

Previously function for try_from_os_str to get Option<Vec<u8>> required signature Result<Vec<u8>, OsString>, now it requires Result<Option<Vec<u8>>, OsString>.

This resulted in break by cargo update.

vi added a commit to vi/websocat that referenced this issue Jun 10, 2019
@vi
Copy link
Author

vi commented Jun 10, 2019

Additionally that argument stops being optional and starts being required.

@TeXitoi TeXitoi added the bug This is a BUG. The fix may be released in a patch version even if considered breaking label Jun 10, 2019
@TeXitoi
Copy link
Owner

TeXitoi commented Jun 10, 2019

Mmm, so #188 is a breaking change.

@TeXitoi
Copy link
Owner

TeXitoi commented Jun 10, 2019

0.2.17 yanked

@TeXitoi
Copy link
Owner

TeXitoi commented Jun 10, 2019

As 0.2.17 is yanked, this issue is now fixed. Feel free to ask anything if you're blocked.

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a BUG. The fix may be released in a patch version even if considered breaking
Projects
None yet
Development

No branches or pull requests

2 participants