Update and improve documentation #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also update documentation in src/lib.rs, I'm working on it |
|
@TeXitoi That's the docs I've been writing for a few days. What do you think about it? If you're fine I believe this is ready to go once we're dealt with these TODOs |
|
There is strange test failure on travis. |
|
My fault, didn't see through that doc tests are actually working. I'm fixing, in the meantime, could you please state your opinion about this changes? And TODOs |
TeXitoi
requested changes
Aug 30, 2019
Don't ever be sorry to me for thing like that! Like you said once - we volunteer our free time here and therefore have no obligation. If I get to think you're missing something I'll just ping you :) |
|
Added |
TeXitoi
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214
@TeXitoi There are a couple of TODOs in changelog, I could use some advise there