Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When linking sentences in the advanced search, more languages appear, even if they're not selected in the user's profile #1783

Closed
Guybrush88 opened this issue Feb 15, 2019 · 3 comments
Assignees
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Milestone

Comments

@Guybrush88
Copy link

as reported by Aiji on the wall:

Advanced search:
English, display translations in French
Limit to sentences having French indirect translations.

Only English and French are displayed.

Link one French => All translations are now displayed.

Is it intended behavior?
(I do not think so, and that is quite a bother when doing some linking work)

second post:

If I link one French sentence, then all translations will appear.
The problem will not happen if you restrict the langages to be displayed in your profile. That's usually how I do it, but this time I forgot so I faced this situation (maybe I, or somebody else, already mentioned it in the past).

https://tatoeba.org/ita/wall/show_message/31332#message_31332

@trang trang added the bug Issue that describes a problem with a feature that doesn't work as expected. label Feb 15, 2019
@ckjpn
Copy link

ckjpn commented Feb 19, 2019

The same thing happened before the update to the latest CakePHP, so it's not a change in the way the website works.

It never really bothered me. However, I can see how it might be irritating on a smart phone.

@ckjpn
Copy link

ckjpn commented Feb 25, 2019

Actually, this is very irritating when trying to do something like that following.

  1. Find all English sentences with audio that have an indirect link to a Japanese sentence.

https://tatoeba.org/eng/sentences/search?query=&from=und&to=jpn&orphans=no&unapproved=no&user=&tags=&list=4000&has_audio=&trans_filter=limit&trans_to=jpn&trans_link=indirect&trans_user=&trans_orphan=&trans_unapproved=&trans_has_audio=&sort=words

  1. Link the indirectly-linked Japanese sentence that matches.

What happens is that all the other translations appear at this point, and you have to scroll past them all.

If this behavior could be changed, it would be a lot faster to get matching indirectly-linked sentences linked.

@trang trang self-assigned this Mar 22, 2020
trang added a commit that referenced this issue Apr 2, 2020
Re #1783.

We're sending the value of the translation filter as a query param.
- When linking/unlinking, we return translations in the language set in the query param.
- When adding a translation, we concatenate new translations to the ones displayed because the user could be adding a translation in a different language.
trang added a commit that referenced this issue Apr 6, 2020
Re #1783.

We're sending the value of the translation filter as a query param.
- When linking/unlinking, we return translations in the language set in the query param.
- When adding a translation, we concatenate new translations to the ones displayed because the user could be adding a translation in a different language.
@jiru
Copy link
Member

jiru commented Feb 4, 2021

I think this regression has been introduced by 5be6155.

@jiru jiru closed this as completed in d6c7b79 Feb 22, 2021
@jiru jiru added this to the 2021-02-28 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

4 participants