Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run prettier on CI #5241

Merged
merged 5 commits into from
Dec 30, 2023
Merged

chore: Run prettier on CI #5241

merged 5 commits into from
Dec 30, 2023

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 30, 2023

Ensures new PRs pass prettier linting. Uses the new prettier v4 alpha which is extremely fast: https://prettier.io/blog/2023/11/30/cli-deep-dive

Prettier v4 did not run with Node 16 - I've updated this to Node 18. This is not breaking as it is only required for our workspace tools, and has no impact on the browser-targeting packages.

See also: TanStack/query#6466

@lachlancollins lachlancollins merged commit f4356c0 into TanStack:main Dec 30, 2023
1 check passed
@lachlancollins lachlancollins deleted the add-prettier-lint branch December 30, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant