Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useSortBy): fix the bug that causes flatRows to be incorrect when sorting and using subRows #2443

Merged

Conversation

aaryn101
Copy link
Contributor

This should also fix #2303, though obviously I was noticing different symptoms.

@dbertella
Copy link

What's the status of this pr? I'm having this exact issue, I was going to report, can we move forward or is there any blocker?

@dbertella
Copy link

If someone else lend here, as a work around I'm sorting the data before pass them as parameter to useTable hook, but yeah it's not great. Anything we can help on this one? (of course this will work as initial sorting, not sure what happens if you update sorting manually)

@aaryn101
Copy link
Contributor Author

aaryn101 commented Jul 6, 2020

@tannerlinsley Would you please take a look at this PR?

@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-table/2xomhvxcn
✅ Preview: https://react-table-git-fork-aaryn101-bugfix-fix-flatrows-when-sorting.tannerlinsley.vercel.app

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 7.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Chase-Dickerson
Copy link

@aaryn101, can you take another look at #2303? This PR did not address that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested SubRows Not Sorting
4 participants