Nested SubRows Not Sorting

[Chase-Dickerson]

Describe the bug
SubRows do not sort beyond a parent subRow of length 1.

Provide an example via Codesandbox!
https://codesandbox.io/s/nice-surf-hzprc

Steps To Reproduce (required)
Steps to reproduce the behavior:

1. Go to the sandbox
2. Click on any of the info columns to apply sorting
3. Notice that no sorting occurs

Expected behavior
SubRows should sort at any depth.

Desktop / Smartphone:

• OS: Any
• Browser: Any
• Version: Any

Additional context
The bug is caused by an early termination of subRow sorting, which occurs on this line:
https://github.com/tannerlinsley/react-table/blob/v7.0.5/src/plugin-hooks/useSortBy.js#L324
(EDIT: Updated link to point to version of react-table where issue was noticed)

Proposed Solution
Adjust the check for skipping subRow sorting so that it only skips subRows if the length of subRows is zero (i.e. change: !row.SubRows || row.subRows.length <= 1 to !row.SubRows || row.subRows.length === 0).

[dbertella]

oh wow thanks for this I was going to open the same issue today

[tannerlinsley]

🎉 This issue has been resolved in version 7.3.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Chase-Dickerson]

This issue is still not resolved on v7.3.4 or higher. See the provided sandbox, which references latest react-table (v7.5.1). @tannerlinsley

[aaryn101]

@Chase-Dickerson I just tried it out on the sandbox, and it seems to be working. What am I missing?

[Chase-Dickerson]

@aaryn101 Child rows do not sort when there is a single sub-row. Sorting is terminating too early because it sees a sub-row of length 1, which by itself constitutes as "sorted," ignoring other sub-rows further down the chain.

[aaryn101]

@Chase-Dickerson Ahh, I see. I'll try to find some time this week to look into a fix.

[ghost]

@aaryn101 Look at #2633
@tannerlinsley Can you merge this PR