There is no alternative language record #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been changed. No language page record is created, but a normal page record in an alternative language.
garvinhicking
requested changes
May 8, 2024
Co-authored-by: Garvin Hicking <[email protected]>
Co-authored-by: Garvin Hicking <[email protected]>
It does not matter if they are all fields. The user will see them. That is enough.
|
@garvinhicking would you agree to resolve open issues in a follow up so this can be merged? |
garvinhicking
approved these changes
Jul 13, 2024
I just made some adjustments, with those I'D be good to merge this and address further things in a follow up (which wouldn't be needed at least from my side now) |
linawolf
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been changed. No language page record is created, but a normal page record in an alternative language.