Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking, api] Removed /api/get/root route #1154

Merged
merged 10 commits into from
May 6, 2024
Merged

Conversation

CommanderStorm
Copy link
Member

Proposed Changes (include Screenshots if possible)

  • Currently the api response for the root route is quite different compared to other routes
  • => removing it allows for some refactoring nessesary for the calendar PR

@jakobkoerber
The TCA does not use this subfeature/weirdness, but still a minor headsup about this API removal ^^
I don't think this really matters to you.

How to test this PR

  1. See that the

How has this been tested?

  • See above

Checklist

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@jakobkoerber
Copy link
Member

@CommanderStorm is there any chance this affects the TCA? We're using these endpoints:

case NavigaTumApiServiceSearch _:
        return "api/search";
      case NavigaTumApiServiceDetails details:
        return "api/get/${details.id}";
      case NavigaTumApiServiceImages images:
        return "cdn/maps/roomfinder/${images.id}";
      case NavigaTumApiServiceOverlayImages overlayImages:
        return "cdn/maps/roomfinder/${overlayImages.id}";
    }

@CommanderStorm
Copy link
Member Author

CommanderStorm commented May 6, 2024

@jakobkoerber
Since the TCA does not show root (that is the front-page you currently see with "Standorte") and this is virtual root of all other entries => not visible in any other room, not linkable due to different data and not visible in the search
=> The TCA is not affected.

@CommanderStorm CommanderStorm enabled auto-merge (squash) May 6, 2024 12:55
@CommanderStorm CommanderStorm merged commit f4fcf71 into main May 6, 2024
14 checks passed
@CommanderStorm CommanderStorm deleted the removed-root-route branch May 6, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants