Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement issue for breaking API changes #130

Open
CommanderStorm opened this issue May 25, 2022 · 7 comments
Open

Announcement issue for breaking API changes #130

CommanderStorm opened this issue May 25, 2022 · 7 comments
Labels

Comments

@CommanderStorm
Copy link
Member

CommanderStorm commented May 25, 2022

This Issue tracks:

  • who uses the API,
  • what features you are using and
  • what change-timelines ("I need 3 Weeks at minimum, because ...") you would prefer.

If you have implemented a part of the API, please note down in the comments which ones. Doing so will indicate, that we will have to keep this API in a stable state and cannot do breaking changes without the change-timeline you require.

We will use this Issue to note breaking API changes.

There are some things about compatibility and assumptions we are making:

  • Adding fields should never break your Application
  • If we differ from the openapi spec this is a bug! Please report it ^^
  • Undocumented behaviour is not relied upon (tell us if something is undocumented)
@CommanderStorm
Copy link
Member Author

We have renamed nb_hits to estimatedTotalHits in 9564038

Since nobody has commented on this issue, this is change is going online immediately and without any backwards compatability.

@PiotrKedra

This comment was marked as outdated.

@octycs octycs changed the title Announcement issue for API changes Announcement issue for breaking API changes Aug 15, 2022
@CommanderStorm
Copy link
Member Author

We have added the localization of the details' endpoint via the ?lang=en query parameter

@COM8

This comment was marked as outdated.

@CommanderStorm CommanderStorm mentioned this issue Jan 28, 2023
2 tasks
@CommanderStorm
Copy link
Member Author

We have merged the /health and the /source_code endpoints into the /status endpoints
See this PR for the full discussion.
Given that nobody has indicated that he/she is using this API, this is going into production this evening.

@CommanderStorm
Copy link
Member Author

CommanderStorm commented May 6, 2024

After looking into what #472 needs I have come to the conclusion that this feature would be simpler if we did not have to have two details-responses (one for /api/get/root and one for /api/get/{id}).
=> /api/get/root is slated for removal in #1154

Given that nobody has indicated that he/she is using this API, this is going into production at the end of the day.

@CommanderStorm
Copy link
Member Author

poi.nearby_public_transport.mvg was moved into the dedicated /locations/{id}/nearby endpoint.
Reason:

  • nobody currently uses that data and it is somewhat large => not worth transmitting for everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants