Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Revert): "chore(starr): Improve streaming service CFs" #2000

Conversation

bakerboy448
Copy link
Contributor

Reverts #1992

Major breaking change. Prevents future Streaming Services renames. This was not tested in Sonarr prior to merging and breaks renaming.

Poor assumptions and logic was leveraged from 13780d7 / #1950

Copy link
Contributor

github-actions bot commented Jul 1, 2024

@bakerboy448 your pull request title "fix(Revert) "chore(starr): Improve streaming service CFs"" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section Area: Starr Custom Formats Issue is related to custom formats labels Jul 1, 2024
@bakerboy448 bakerboy448 changed the title fix(Revert) "chore(starr): Improve streaming service CFs" fix(Revert): "chore(starr): Improve streaming service CFs" Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

@bakerboy448 your pull request title "fix(Revert) "chore(starr): Improve streaming service CFs"" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

@bakerboy448 bakerboy448 merged commit e1cd881 into master Jul 1, 2024
10 of 11 checks passed
@bakerboy448 bakerboy448 deleted the revert-1992-chore/improve-and-standardise-streaming-service-regex branch July 1, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related Area: Starr Custom Formats Issue is related to custom formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants