-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(starr): Moved webdl and webrip into Amazon regex to prevent incorrect matches #1950
fix(starr): Moved webdl and webrip into Amazon regex to prevent incorrect matches #1950
Conversation
Did a little check what i could find with amazon in the title and added it to your regex test case |
@TRaSH- Better now https://regex101.com/r/IR8Qbx/8 I added a negative lookbehind for "the.amazon" as that seems to be a common pattern, but no sane person would label a streaming service "the streaming service". I've left all the resolutions in the regex. Removing them would have fixed the incorrect matches as well. Whilst I was not able to find any releases where the resolution is present and WEB-DL/Web-Rip is not, I have only been scrolling through prowlarr results, so cannot be certain that there are none. |
@wheat4714 this is a way simpler version and it still catches 90% of those cases. the last 10% are just horribly named releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make the same adjustment for the radarr cf
7440b22
to
6d7d9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add back the removed WEBDL
and WEBRIP
conditions
…//github.com/wheat4714/Guides into fix/Amazon-CF-should-not-match-episode-names
Reverting this. Breaking change that materially breaks sonarr rename functionality for existing episodes. This was not actually tested in sonarr and only has blind regex performed |
Pull Request
Purpose
I created this pull request because I noticed that Amazon CF was applying to certain TV shows and TV episodes. I noticed that the regex is simply looking for "Amazon" in a word boundary. As this is a dictionary word, it's going to match stuff it shouldn't.
Approach
Instead of matching just "Amazon", it requires additional text either side of, which always comes with these releases. Either the resolution or web-rip / web-dl.
https://regex101.com/r/IR8Qbx/6
Requirements