Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(guides): Improve description for x265 (no HDR/DV), x265 (HD) and SDR (no WEBDL) #1941

Merged
merged 9 commits into from
May 22, 2024
Merged

feat(guides): Improve description for x265 (no HDR/DV), x265 (HD) and SDR (no WEBDL) #1941

merged 9 commits into from
May 22, 2024

Conversation

TRaSH-
Copy link
Contributor

@TRaSH- TRaSH- commented May 19, 2024 •
edited
Loading

Pull Request

Purpose

Improve description for x265 (no HDR/DV), x265 (HD) and SDR (no WEBDL)

Approach

Tried to improved description for x265 (no HDR/DV), x265 (HD) and SDR (no WEBDL), and asked in Discord if the users that had issues understanding the former description if they preferred the new description and with it understand the description.

Open Questions and Pre-Merge TODOs

  • Tested the changes locally for errors

Requirements

@github-actions github-actions bot added Area: Sonarr Sonarr Related Area: Radarr Radarr Related Area: Backend Backend Changes, not related to a specific section labels May 19, 2024
@TRaSH- TRaSH- requested a review from a team May 19, 2024 16:58
@TRaSH- TRaSH- linked an issue May 19, 2024 that may be closed by this pull request
[Request] (Guide): Improve description for x265 (no HDR/DV) and x265 (HD) #1940
Closed
yammes08
yammes08 previously approved these changes May 19, 2024
View reviewed changes
@yammes08
Copy link
Contributor

I've approved it, but @zakkarry might want to take a language/grammar pass?

zakkarry
zakkarry suggested changes May 19, 2024
View reviewed changes
Copy link
Contributor

@zakkarry zakkarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks mostly good, just a few small changes.

Might want to check how the particular bullet points render in the last 2 before merging.

includes/cf-descriptions/x265-no-hdrdv-radarr.md Outdated Show resolved Hide resolved
includes/cf-descriptions/x265-no-hdrdv-sonarr.md Outdated Show resolved Hide resolved
includes/cf/radarr-optional-uhd.md Outdated Show resolved Hide resolved
includes/cf/sonarr-optional-uhd.md Outdated Show resolved Hide resolved
@TRaSH- TRaSH- requested a review from zakkarry May 20, 2024 08:36
@TRaSH-
Copy link
Contributor Author

TRaSH- commented May 20, 2024

This looks mostly good, just a few small changes.

Might want to check how the particular bullet points render in the last 2 before merging.

image

Looks good thnx

@TRaSH- TRaSH- merged commit 0f747c3 into master May 22, 2024
8 checks passed
@TRaSH- TRaSH- deleted the feat/guides-improve-description-x265-hd-and-sdr-no-webdl branch May 22, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkarry zakkarry zakkarry approved these changes

@yammes08 yammes08 yammes08 left review comments

Assignees
No one assigned
Labels
Area: Backend Backend Changes, not related to a specific section Area: Radarr Radarr Related Area: Sonarr Sonarr Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] (Guide): Improve description for x265 (no HDR/DV) and x265 (HD)
3 participants
@TRaSH- @yammes08 @zakkarry