version number, take 2 #2599
Draft
version number, take 2 #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for actual use, yet — in large part untested, and prose not written. This version is simply for Council to see if they like it.
solves the problem for which the original ticket was opened, IIRC).
a working, if not ideal, state
constraintDecl element
…l to topographical.
|
All tests pass on my local system (Padfoot, not in the Docker). |
There was a problem hiding this comment.
I think this needs a new remarks element explaining that its content can be one of four different formats of version, and perhaps pointing to the definitions of the dataSpecs. It's going to be quite challenging to figure out which specific dataSpec you're not quite aligning with when you get error messages typing a version string.
There was a problem hiding this comment.
Agreed, although I have no intention of putting in that effort until Council approves the general approach.
purpose, re-create table of modules. (Note that new table reverses the position of the “Where defined” and “FPI” columns.)
* Bug fix: Constraint was looking for _all_ descendant text nodes of eg element, not just child text nodes. That means that if there is any phrase-level encoding in an eg element there is more than one text node that has (for example) position()=last(), and the XPath fails because only one item is allowed as the first argument to matches(). * Better fix: Per suggestion of @martindholmes, instead of trying to select the correct descendant text node(s), just examine the string value of the entire eg element as a whole. The string() function call is not technically necessary (because matches() wants a string there, it would happen automagically), but its use makes what we are doing explicit and obvious.
table of modules — re-generated based on new utility
* Remove vestiges of calendar= deprecation * replaced deletion of calendar attribute on date with deletion of att.calendarSystem --------- Co-authored-by: Syd Bauman <[email protected]>
…s, added clarification to example in line spec
add `<constraintDecl>`
adding xml:lang=en to constraintDecl’s constraintSpec.
add `@scope` to `<language>` by factoring a new class from `@scope` of att.handFeatures
attribute class inclusions in ST (the "tei" module). No changes to prose or schema, just re-arranged the sequence of attribute specifications and added comments to explain it.
Remove dead link
improve editability of inclusion of attribute classes into ST
…able Guessing @trishaoconnor did not notice this one was assigned to her; merging on her behalf tonight so we need not discuss at meeting tomorrow.
…ding css rule for a.notelink (#2636)
Updated specs for `<line>` and `<lb>`
…e of teidata.duration.iso & teidata.version
…after manual merge of application and att.styleDef
solves the problem for which the original ticket was opened, IIRC).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the moment this branch is a partiallly working version of version sublcasses that is NOT ready for actual use, yet — in large part untested, and prose not written. This version is simply for Council to see if they like it, but (I think) it does address the problem for which original ticket was open.