improve editability of inclusion of attribute classes into ST #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attribute class inclusions in ST (the "tei" module). No changes to prose or schema, just re-arranged the sequence of attribute specifications and added comments to explain it.
ebeshero
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
This passes tests and doesn't break the build for me locally. Also the big table in ST just looks a lot better and is organized more logically in the resulting build of the Guidelines, though I think that might be paired with another recent update in Stylesheets on my dev branch.
|
|
||
| Within each set classes are specified in alpahabetic | ||
| order. | ||
| --> |
There was a problem hiding this comment.
Thanks, @sydb ! This comment is super helpful "future proofing" for editors of this page. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On trying to explain attribute specification inclusion on #2643, it occurred to me that it would be more useful to future editors to have the explanation in ST (the "tei" module) itself. While I was there I also re-arranged the order of attribute class inclusions, hopefully in a way that is easier to understand. No changes to prose or schema, just re-arranged the sequence of attribute specifications and added comments to explain it.
This necessitated one minor change in the tests, as the order of Schematron constraints (some of which are specified in the attribute classes) is now a bit different.
Note to potential reviewers: I think passing tests is probably sufficient (and they all pass in my Docker). But if you look at the files themselves, definitely hide whitespace differences.