[#12230] Extension Confirm Modal: Misplaced submit buttons on mobile #12401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion confirmation modal on mobile. The problem had to do with padding styling that was attached to the modal-footer class. Instead of removing that styling, as I didn't know what other modals used it, I decided to use bootstrap5 classes that override the padding for the buttons. Resolves: #12230
jasonqiu212
reviewed
Apr 21, 2023
There was a problem hiding this comment.
Hi @hollymvargas, Thank you for your contribution!
Would it be possible to update the snapshot tests as well? I believe they are currently failing from the changes.
…sion confirmation modal. Changed the line that was failing to match the new changes I made. Related to: #12230
|
Ready for review! I updated the test accordingly. |
jasonqiu212
approved these changes
Apr 21, 2023
weiquu
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12230
Outline of Solution
The problem had to do with padding styling that was attached to the modal-footer class. Instead of removing that styling, as I didn't know what other modals used it, I decided to use bootstrap5 padding classes to override it.
Screenshot before the fix:
Screenshot after the fix:
