Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension Confirm Modal: Misplaced submit buttons on mobile #12230

Closed
jasonqiu212 opened this issue Mar 20, 2023 · 0 comments · Fixed by #12401
Closed

Extension Confirm Modal: Misplaced submit buttons on mobile #12230

jasonqiu212 opened this issue Mar 20, 2023 · 0 comments · Fixed by #12401
Labels
c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors

Comments

@jasonqiu212
Copy link
Contributor

jasonqiu212 commented Mar 20, 2023 •
edited
Loading

problem

Steps to reproduce

  1. Access the production website on mobile.
  2. Login as an instructor and go to Home.
  3. For any sessions, click on Edit.
  4. Scroll to section with link to Individual Deadline Extensions.
  5. Click on Individual Deadline Extensions.
  6. Extend the deadline for any student and click Extend / Edit. A modal will pop up to confirm the extension duration.
  7. Click on any duration and click Save changes. A modal with the problematic buttons will pop up.

Expected behaviour

  • Submit buttons should be inside the footer of the modal, similar to the behavior of other modals.

Actual behaviour

  • Buttons are outside of the footer of the modal.

Additional info
@jasonqiu212 jasonqiu212 added the c.Bug Bug/defect report label Mar 20, 2023
@zhaojj2209 zhaojj2209 added the good first issue Easy; restricted for first-time contributors label Mar 27, 2023
@hollymvargas hollymvargas mentioned this issue Apr 20, 2023
Merged
zhaojj2209 pushed a commit that referenced this issue Apr 22, 2023
@hollymvargas
[#12230] Extension Confirm Modal: Misplaced submit buttons on mobile (#…
b235986 
…12401)

* Fixes the issue where the submit buttons are not visible on the extension confirmation modal on mobile.

The problem had to do with padding styling that was attached to the modal-footer class. Instead of removing that styling, as I didn't know what other modals used it, I decided to use bootstrap5 classes that override the padding for the buttons.

Resolves: #12230

* Modifies a snapshot test to properly reflect new changes to the extension confirmation modal.

Changed the line that was failing to match the new changes I made.

Related to: #12230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#12230] Extension Confirm Modal: Misplaced submit buttons on mobile
2 participants
@jasonqiu212 @zhaojj2209