Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructor view session results (course-wide): Improve display of no-response card header #12290

Closed
zhaojj2209 opened this issue Mar 28, 2023 · 2 comments · Fixed by #12396
Closed
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.

Comments

@zhaojj2209
Copy link
Contributor

The current display of the no-response card header doesn't work well on mobile:
photo_2023-03-28 14 00 24

Suggestion: switch to column format on mobile screen sizes, similar to the card headers for the instructor edit page (example below).
Screenshot 2023-03-28 at 15 07 46

The card header should also be changed to be a button semantically so that it can be picked up by screen readers. For the approach, do refer to the card headers in the instructor edit sessions page.

@zhaojj2209 zhaojj2209 added a-UIX User Interface, User eXperience, responsiveness good first issue Easy; restricted for first-time contributors c.Bug Bug/defect report p.VeryLow Just cosmetic value only. Do only if we have spare resources. labels Mar 28, 2023
@rhyses-pieces
Copy link
Contributor

@zhaojj2209 Hiya, I'm setting up my local dev environment for this project and I'm interested in working on this issue.

@zhaojj2209
Copy link
Contributor Author

@rhyses-pieces Feel free to submit a PR for this issue.

weiquu added a commit that referenced this issue Apr 23, 2023
…ay of no-response card header (#12396)

* reformatted no-response for consistency

* fix formatting to match style guide

* forgot margin

* switch chevron to right and fix a11y issues

* switch card-header to button again

* fix e2e testing failure

* fix a11y issues

---------

Co-authored-by: Wei Qing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-UIX User Interface, User eXperience, responsiveness c.Bug Bug/defect report good first issue Easy; restricted for first-time contributors p.VeryLow Just cosmetic value only. Do only if we have spare resources.
Projects
None yet
2 participants