Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Next Write Time Passed to Serial or Hub to be Dynamic #302

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Change Next Write Time Passed to Serial or Hub to be Dynamic #302

merged 3 commits into from
Jan 5, 2021

Commits on Jan 5, 2021

  1. Change Next Write Time Passed to Serial or Hub to be Dynamic 

    The write time was previously a timestamp that became fixed as
soon as the protocol wrote it to the Serial or Hub object.  The
Serial or Hub object would then sit on the message until that
time.

This design overlooked the possibility that the next write time
could change after the protcol sent the message to the Serial or
Hub.  This can happen if another message arrives, and the wait
time needs to be extended, or if a Link Cleanup report arrives
which could decrease the wait time.  This likely didn't cause
many errors, but wasn't quite right.

Now the write time is passed as a function which returns the
dynamic write time, so that the Serial and Hub ge the most up to
date calculation.
    @krkeegan
    krkeegan committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    710b40f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/dev' into Dynamic_Write_Time

    @krkeegan
    krkeegan committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    015e8b9 View commit details
    Browse the repository at this point in the history

  3. Update Changelog

    @krkeegan
    krkeegan committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    90a2808 View commit details
    Browse the repository at this point in the history