Change Next Write Time Passed to Serial or Hub to be Dynamic #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The write time was previously a timestamp that became fixed as soon as the protocol wrote it to the Serial or Hub object. The Serial or Hub object would then sit on the message until that time. This design overlooked the possibility that the next write time could change after the protcol sent the message to the Serial or Hub. This can happen if another message arrives, and the wait time needs to be extended, or if a Link Cleanup report arrives which could decrease the wait time. This likely didn't cause many errors, but wasn't quite right. Now the write time is passed as a function which returns the dynamic write time, so that the Serial and Hub ge the most up to date calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The write time was previously a timestamp that became fixed as
soon as the protocol wrote it to the Serial or Hub object. The
Serial or Hub object would then sit on the message until that
time.
This design overlooked the possibility that the next write time
could change after the protcol sent the message to the Serial or
Hub. This can happen if another message arrives, and the wait
time needs to be extended, or if a Link Cleanup report arrives
which could decrease the wait time. This likely didn't cause
many errors, but wasn't quite right.
Now the write time is passed as a function which returns the
dynamic write time, so that the Serial and Hub ge the most up to
date calculation.