make requiredPaymentDetails optional

[finn-block]

fixes #90

[changeset-bot]

⚠️ No Changeset found

Latest commit: c974e39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 12

@tbdex/protocol

• Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

• Project entry file: packages/http-client/src/main.ts

📄 File: packages/http-client/src/errors/request-error.ts
⚠️ extractor:ae-missing-release-tag: "RequestErrorParams" is part of the package's API, but it is missing a release tag (@alpha, @beta, @public, or @internal) #L1
⚠️ extractor:ae-undocumented: Missing documentation for "RequestErrorParams". #L1
⚠️ extractor:ae-undocumented: Missing documentation for "recipientDid". #L13
⚠️ extractor:ae-undocumented: Missing documentation for "url". #L14

📄 File: packages/http-client/src/errors/request-token-error.ts
⚠️ extractor:ae-missing-release-tag: "RequestTokenErrorParams" is part of the package's API, but it is missing a release tag (@alpha, @beta, @public, or @internal) #L3
⚠️ extractor:ae-undocumented: Missing documentation for "RequestTokenErrorParams". #L3

📄 File: packages/http-client/src/errors/response-error.ts
⚠️ extractor:ae-missing-release-tag: "ResponseErrorParams" is part of the package's API, but it is missing a release tag (@alpha, @beta, @public, or @internal) #L3
⚠️ extractor:ae-undocumented: Missing documentation for "ResponseErrorParams". #L3
⚠️ extractor:ae-undocumented: Missing documentation for "statusCode". #L15
⚠️ extractor:ae-undocumented: Missing documentation for "details". #L16
⚠️ extractor:ae-undocumented: Missing documentation for "recipientDid". #L17
⚠️ extractor:ae-undocumented: Missing documentation for "url". #L18

@tbdex/http-server

• Project entry file: packages/http-server/src/main.ts

---

TBDocs Report Updated at 2024-02-21T01:05:31Z c974e39

[finn-block]

left this in draft state because I wasn't sure if further checks were needed. It looks like this field is used in a protoc/src/message-kinds/rfq.ts where it is assumed to be set. Should we have some safety around checking there? I'm missing a lot of context around what this field is and how it may be used.

[diehuxx]

It looks like this field is used in a protoc/src/message-kinds/rfq.ts where it is assumed to be set.

@finn-tbd Good catch. The fix for that would conflict with #141 (which will also make the TS compiler strict enough to catch errors like that in the future). Once #141 is merged, I can push a commit to this PR fixing protoc/src/message-kinds/rfq.ts is that's alright with you.

[finn-block]

sounds good

[diehuxx]

TODO:

• After Allow Offering.data.requiredClaims to be optional in JSON Schema tbdex#228 is merged, update tbdex submodule back to main.

[codecov]

Codecov Report

Merging #139 (c974e39) into main (ebefc54) will increase coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   92.48%   92.52%   +0.03%     
==========================================
  Files          37       37              
  Lines        2995     3011      +16     
  Branches      321      326       +5     
==========================================
+ Hits         2770     2786      +16     
  Misses        225      225              

Components	Coverage Δ
protocol	93.46% <100.00%> (+0.06%)	⬆️
http-client	93.63% <ø> (ø)
http-server	89.49% <ø> (ø)

[finn-block]

Blocked pending TBD54566975/tbdex#227

[KendallWeihe]

one comment added, but not strictly required (opinionated take)

feel free to merge once this blocking PR is merged TBD54566975/tbdex#227