Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

make requiredPaymentDetails optional #90

Closed
mistermoe opened this issue Nov 22, 2023 · 0 comments · Fixed by #139
Closed

make requiredPaymentDetails optional #90

mistermoe opened this issue Nov 22, 2023 · 0 comments · Fixed by #139
Assignees
@diehuxx
Labels
bug Something isn't working

Comments

@mistermoe
Copy link
Member

this should be optional as per the spec
@mistermoe mistermoe added the bug Something isn't working label Nov 22, 2023
finn-block added a commit that referenced this issue Jan 16, 2024
@finn-block
make requiredPaymentDetails optional
446724e 
fixes #90
@finn-block finn-block mentioned this issue Jan 16, 2024
Merged
finn-block added a commit that referenced this issue Jan 16, 2024
@finn-block
make requiredPaymentDetails optional
6b67fe0 
fixes #90
diehuxx pushed a commit that referenced this issue Jan 20, 2024
@finn-block
make requiredPaymentDetails optional
e1897d6 
fixes #90
diehuxx pushed a commit that referenced this issue Feb 13, 2024
@finn-block
make requiredPaymentDetails optional
3c752ec 
fixes #90
diehuxx pushed a commit that referenced this issue Feb 21, 2024
@finn-block
make requiredPaymentDetails optional (#139)
ffc3af8 
* make requiredPaymentDetails optional

fixes #90

* Handle requiredPaymentDetails undefined for RFQ verification

* Require paymentDetails be omitted if requiredPaymentDetails omitted

* PR comment - else not continue

* Update submodule to latest main

* woops

---------

Co-authored-by: Diane Huxley <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diehuxx diehuxx

Labels
bug Something isn't working
Projects
SDK Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make requiredPaymentDetails optional TBD54566975/tbdex-js
2 participants
@mistermoe @diehuxx