Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Update to a newer ssi-sdk revision #513

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

vlad-tim
Copy link
Contributor

@vlad-tim vlad-tim commented Jun 6, 2023

Overview

Update to a newer revision of ssi-sdk to account for changes made in TBD54566975/ssi-sdk#399 and in between the existing version of ssi-sdk in use.

Description

In the context of issue TBD54566975/ssi-sdk#395 , an update in ssi-service is required. There is also a commit TBD54566975/ssi-sdk@70d1269 between the old and the new revision of ssi-sdk, with some breaking changes, which is covered by this PR as well.

How Has This Been Tested?

Ran mage cblt and mage integration without errors.

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING document.
  • My code is consistent with the rest of the project
  • I have tagged the relevant reviewers and/or interested parties
  • I have updated the READMEs and other documentation of affected packages

References

Copy link
Contributor

@andresuribe87 andresuribe87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vlad-timofeev ! As soon as #516 is merged in, you can merge and tests should pass.

@codecov-commenter
Copy link

Codecov Report

Merging #513 (f72785d) into main (2ba63e1) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   20.71%   20.70%   -0.01%     
==========================================
  Files          49       49              
  Lines        5890     5891       +1     
==========================================
  Hits         1220     1220              
- Misses       4445     4446       +1     
  Partials      225      225              
Impacted Files Coverage Δ
pkg/service/did/web.go 0.00% <0.00%> (ø)
internal/keyaccess/dataintegrity.go 58.33% <100.00%> (ø)

@andresuribe87 andresuribe87 merged commit 34bcd3f into TBD54566975:main Jun 7, 2023
tlongwell-block pushed a commit that referenced this pull request Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants