IsValid should take in a context and return err

[andresuribe87]

The function below is hiding information from the users of the SDK, so it's difficult to understand what failed. The return type should be error.

Additionally, it should take in a context.Context as it's first parameter because it's doing a network lookup.

It's debatable whether the name of the function should stay as IsValid. If returning an error, consider naming Validate.

ssi-sdk/did/web/web.go

Line 32 in a087372

func (d DIDWeb) IsValid() bool {

[vlad-tim]

I have not been able to find usages of the function that have to be adjusted as the function signature changes, can you advise?

[andresuribe87]

Thanks for taking a look @vlad-timofeev !

There are no internal uses of this function. The SSI-service consumes this lib, so when it's updated, we'll need to make sure to also update the callers in there.

For this issue I would recommend adding a unit test so we know this works as expected.

[vlad-tim]

Thank you for clarifying @andresuribe87 !

Created #399

[vlad-tim]

@andresuribe87 is there anything else that should be updated to account for changes in #399 ?

[andresuribe87]

There isn't, thanks @vlad-timofeev !