Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

ID of credentials can now be dereferenced. #507

Merged
merged 9 commits into from
Jun 8, 2023

Conversation

andresuribe87
Copy link
Contributor

Overview

Fixes #500

Description

This uses the service base configuration.

How Has This Been Tested?

Updated a test so that it failed before and passes after.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Merging #507 (82fa883) into main (d25e679) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   20.70%   20.60%   -0.11%     
==========================================
  Files          49       49              
  Lines        5891     5921      +30     
==========================================
  Hits         1220     1220              
- Misses       4446     4476      +30     
  Partials      225      225              
Impacted Files Coverage Δ
integration/common.go 1.92% <0.00%> (-0.05%) ⬇️
pkg/server/router/credential.go 3.30% <0.00%> (+0.01%) ⬆️
pkg/service/credential/service.go 0.00% <0.00%> (ø)
pkg/service/credential/status.go 0.00% <0.00%> (ø)
pkg/service/credential/storage.go 1.60% <0.00%> (-0.01%) ⬇️

@andresuribe87 andresuribe87 merged commit 4c7925c into TBD54566975:main Jun 8, 2023
tlongwell-block pushed a commit that referenced this pull request Jun 8, 2023
* ID of credentials can now be dereferenced.

* Fix the integration tests

* spec

* spec

* Spec and some changes.

* spec
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update credential creation so the ID is a URL
3 participants