Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Update credential creation so the ID is a URL #500

Closed
andresuribe87 opened this issue May 30, 2023 · 1 comment · Fixed by #507
Closed

Update credential creation so the ID is a URL #500

andresuribe87 opened this issue May 30, 2023 · 1 comment · Fixed by #507
Labels
credentials server server development
Milestone
Milestone v0.0

Comments

@andresuribe87
Copy link
Contributor

The spec recommends that IDs can be dereferenced. This is currently not supported by ssi-service.

We should:

  • Set a config parameter for the base URL for the service (not sure if it exists already).
  • When creating credentials, call the SetID(id) method with id = baseURL + "/v1/credentials/" + uuid.NewString(). This will allow the ID to be dereferenced.
@github-project-automation github-project-automation bot moved this to 🆕 New in SSI May 30, 2023
@decentralgabe
Copy link
Member

the config exists, and this is what is going on for schemas already as per #494. we should be careful the config still works after #502

@decentralgabe decentralgabe moved this from 🆕 New to 📋 Backlog in SSI Jun 1, 2023
@decentralgabe decentralgabe added this to the Milestone v0.0 milestone Jun 1, 2023
@decentralgabe decentralgabe added server server development credentials labels Jun 1, 2023
@andresuribe87 andresuribe87 mentioned this issue Jun 1, 2023
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in SSI Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
credentials server server development
Projects
No open projects
SSI
Status: ✅ Done
Milestone
Milestone v0.0
Development

Successfully merging a pull request may close this issue.

ID of credentials can now be dereferenced. andresuribe87/ssi-service
2 participants
@andresuribe87 @decentralgabe