Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Config should not expose non-configurable values #502

Closed
decentralgabe opened this issue May 31, 2023 · 2 comments · Fixed by #625
Closed

Config should not expose non-configurable values #502

decentralgabe opened this issue May 31, 2023 · 2 comments · Fixed by #625
Assignees
@decentralgabe
Labels
server server development
Milestone
Milestone v0.0

Comments

@decentralgabe
Copy link
Member 

          this needs to be refactored because we don't want to enable config for setting service endpoints. I'll open a new issue

Originally posted by @decentralgabe in #494 (comment)
@github-project-automation github-project-automation bot moved this to 🆕 New in SSI May 31, 2023
@decentralgabe decentralgabe changed the title this needs to be refactored because we don't want to enable config for setting service endpoints. I'll open a new issue Service endpoints should not be exposed in the service config May 31, 2023
@decentralgabe
Copy link
Member Author

Users should not be able to override the endpoints of the REST API for different services.

Consider moving this into a non-configurable object.

@decentralgabe decentralgabe moved this from 🆕 New to 🔖 Up Next in SSI May 31, 2023
@decentralgabe decentralgabe added this to the Milestone v0.0 milestone May 31, 2023
@decentralgabe decentralgabe added the server server development label May 31, 2023
This was referenced May 31, 2023
Merged
Closed
@decentralgabe
Copy link
Member Author

Similarly, we should not expose setting name, description, and version properties in the config.

@decentralgabe decentralgabe changed the title Service endpoints should not be exposed in the service config Config should not expose non-configurable values Jul 28, 2023
@decentralgabe decentralgabe mentioned this issue Jul 28, 2023
Merged
@decentralgabe decentralgabe self-assigned this Jul 31, 2023
@decentralgabe decentralgabe mentioned this issue Aug 1, 2023
Merged
@decentralgabe decentralgabe moved this from 🔖 Up Next to 👀 In review in SSI Aug 1, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in SSI Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@decentralgabe decentralgabe

Labels
server server development
Projects
No open projects
SSI
Status: ✅ Done
Milestone
Milestone v0.0
Development

Successfully merging a pull request may close this issue.

config moved to serviceinfo singleton TBD54566975/ssi-service
1 participant
@decentralgabe