-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
@tomdaffurn @mistermoe Should we rename this repo to be more generalized if we're going to include both KCC and KBC specs / schemas? Similar to the issue @decentralgabe raised. Another thought is that we could create a |
kbc.schema.json
Outdated
@@ -0,0 +1,54 @@ | |||
{ | |||
"$schema":"https://json-schema.org/draft/2020-12/schema", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we used this version everywhere, just noting that the other schemas use draft 7.
I'd recommend keeping this and let's take an action to update the other schemas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to make sure our libs are set up to handle 2020-12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib support for 2020-12
is largely untested at the moment. we know for a fact that 07 works. if we can get someone with cycles to test 2020-12
across several languages or even just rust, js, go, and dart that'd be awesome
kbc.schema.json
Outdated
{ | ||
"$schema":"https://json-schema.org/draft/2020-12/schema", | ||
"type":"object", | ||
"properties":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also add id
as a top level required property?
kbc.schema.json
Outdated
}, | ||
"issuanceDate":{ | ||
"type":"string", | ||
"format":"date-time" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting that the regex for date-time
is not quite conformant to xml date time as required by the spec
you can find a full regex for xml date time here https://github.com/w3c/vc-data-model/blob/main/schema/verifiable-credential/verifiable-credential-schema.json#L216
Moved to a dir 👍 We should have a conversation about where the schemas should live. I'll post about it elsewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hesitant about 2020-12
for the reasons explained in the comments i left. aside from that looks good!
Signed-off-by: Frank Hinek <[email protected]>
No description provided.