Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Reversible PPi Reactions Irreversible, Part 2 #641

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Make Reversible PPi Reactions Irreversible, Part 2 #641

merged 2 commits into from
Jun 28, 2023

Conversation

Devlin-Moyer
Copy link
Collaborator

Main improvements in this PR:

As mentioned in the re-opening comment on #527:

  • Makes MAR02786, MAR02802, MAR03388, MAR03390, and MAR09508 irreversible
  • Swaps products and reactants of MAR01845, MAR09523, and MAR09546, then makes them irreversible

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Member

@edkerk edkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually checked all changes, looks good to me.

@feiranl
Copy link
Collaborator

feiranl commented Jun 28, 2023

LGTM!

@feiranl feiranl merged commit 2644b74 into SysBioChalmers:develop Jun 28, 2023
@haowang-bioinfo haowang-bioinfo mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants